Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication page layout #442

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

MattPereira
Copy link
Contributor

@MattPereira MattPereira commented Aug 30, 2023

Fixes #440

Changes

  • Opted for multiple paths so that users can be sent a direct link to the sign up page
  • Converted HeaderNav to all tailwind and only using horizontal CTJ logo since no stacked logo seen in figma
  • Created a InputGroup component with tailwind because not sure about using or converting existing Textfield.tsx

Discussion

  • The HeaderNav is using a element links instead of react router Link components because the HeaderNav component is outside the context of react router that is created in Router.tsx
  • How to enable "hot reload" for this project? Clicking the refresh button in browser to see each css change is a nightmare
  • Is there a better way to structure or organize the components related to the authentication page?

Follow Up Issues

Screenshots, if applicable

See Desktop

image

image

See Mobile

image

image

@MattPereira MattPereira changed the title Authentication page Authentication page layout Aug 30, 2023
@MattPereira MattPereira marked this pull request as ready for review September 3, 2023 20:37
@bzzz-coding
Copy link
Member

bzzz-coding commented Sep 5, 2023

  • The HeaderNav is using a element links instead of react router Link components because the HeaderNav component is outside the context of react router that is created in Router.tsx
    I wonder if we should reorganized the router and take advantage of nested routes and outlet, but I really appreciate your problem solving and making everything work with the current router setup.

  • How to enable "hot reload" for this project? Clicking the refresh button in browser to see each css change is a nightmare
    I agree. It would be great if we could reduce the hassle of revealing style changes. Maybe this could be an issue that involve some research on configuring webpack and docker?

  • Is there a better way to structure or organize the components related to the authentication page?
    I wouldn't call it "better" but another approach would be to create a separate Login page and a Signup page, instead of AuthenticationPage + useLocation?
    I also wonder if we should keep the components in the components folder, even if they are only used on this particular page. 🤔

Copy link
Member

@bzzz-coding bzzz-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the login/signup page, @MattPereira ✨ ! I like the idea of creating InputGroup and admire your problem-solving skills 🧠. I also appreciate your comment--let's discuss the next steps and how we can improve our development experience. ❤️

@MattPereira MattPereira merged commit 5191091 into hackforla:main Sep 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build login/signup page layout
2 participants