Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required asterisk to intake form #732

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

JpadillaCoding
Copy link
Member

Closes #715

What changes did you make?

  • Added asterisk based on validation requiring the field
  • Overrided MUI asterisk color to match designs.
  • Redid the label per field.

Rationale behind the changes?

  • Asterisk color was done local to the form and not to the whole website's theme to avoid confusion on color in future usage.
  • Modified how the field label was rendered since some field types required a label to make the asterisk work. Since I was already modifying the label, I made the change to render the label as field.title by handling them in the switch case to better match the figma designs.

Testing done for these changes

  • Compared with db\profile.ts to make sure when validation was set to true/false, the asterisk rendered properly.

What did you learn or can share that is new?(optional)

  • InputLabelProps={{shrink: true}} will make the field label inline to the border, but a label is needed to make it work.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2024-06-22 at 7 58 51 PM
Visuals after changes are applied Screenshot 2024-06-22 at 7 57 32 PM

@erikguntner erikguntner merged commit 5fd8ee9 into main Jun 26, 2024
2 checks passed
@tylerthome tylerthome deleted the add-asterisk-intake-form branch September 7, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: User Acceptance Testing
Development

Successfully merging this pull request may close these issues.

Add required field asterisk
2 participants