Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

683 contact information #753

Merged
merged 10 commits into from
Sep 6, 2024
Merged

683 contact information #753

merged 10 commits into from
Sep 6, 2024

Conversation

johnwroge
Copy link
Member

@johnwroge johnwroge commented Aug 19, 2024

Closes #683

What changes did you make?

  • I added a contact information section to profile.ts to include the required email, phone number, and desired contact method. This included incorporating a linked fields section because the field ids were not accessible within the intakeProfileGroups component.
  • I also added regex expressions to do a quick validation on email and phone number.

Rationale behind the changes?

The preferred contact method was needed in the contact information component and email and phone number needed to be verified based on format.

What did you learn or can share that is new?(optional)

The regex expression used to validate email and phone does not follow best practices, but can be updated to include a separate validation library if needed.
I tried accessing the field ids using hooks (useState, useRef, useEffect), however it didn't work so the linked fields were a workaround. This can be updated later if we have a fixed field id in that section.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screen Shot 2024-08-18 at 9 56 21 PM
Visuals after changes are applied Screen Shot 2024-08-18 at 9 26 41 PM Screen Shot 2024-08-18 at 9 27 38 PM Screen Shot 2024-08-18 at 9 27 24 PM

@tylerthome tylerthome merged commit 04ae4f5 into main Sep 6, 2024
1 of 2 checks passed
@tylerthome tylerthome deleted the 683_contact_information branch September 6, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Information component
2 participants