Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add labels to 'goods' and 'bad' examples #1236

Closed
1 task
Tracked by #1060
sydneywalcoff opened this issue Mar 11, 2024 · 0 comments · Fixed by #1265 or #1276
Closed
1 task
Tracked by #1060

add labels to 'goods' and 'bad' examples #1236

sydneywalcoff opened this issue Mar 11, 2024 · 0 comments · Fixed by #1265 or #1276
Assignees
@hasham-qaiser
Labels
feature: accessibility front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person p-feature: advice https://expungeassist.org/advice priority: medium role: development anything related to code size: 1pt can be done in 6 hours or less
Milestone
Stakeholder Review

Comments

@sydneywalcoff
Copy link
Member

sydneywalcoff commented Mar 11, 2024 •
edited
Loading

Overview

Screen readers(SR) depend on aria-labels to identify custom sections and containers. When evaluating the Advice page before starting the letter generator, SRs will just read the list of good and bads without identifying which is which.

Action Items

  • Add aria-labels to each good and bad item so it identifies them as a good or bad example

Resources/Notes

  • I tested this using the VoiceOver Screen Reader built into MacOs; it includes a tutorial about how to use it.
@sydneywalcoff sydneywalcoff mentioned this issue Mar 11, 2024
Closed
12 tasks
@sydneywalcoff sydneywalcoff added role: development anything related to code priority: medium size: 1pt can be done in 6 hours or less feature: accessibility front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person p-feature: advice https://expungeassist.org/advice labels Mar 11, 2024
@sydneywalcoff sydneywalcoff added this to the Launch Prep milestone Mar 11, 2024
@sydneywalcoff sydneywalcoff mentioned this issue Mar 14, 2024
Open
@hasham-qaiser hasham-qaiser self-assigned this Mar 18, 2024
@hasham-qaiser hasham-qaiser mentioned this issue Mar 18, 2024
Merged
@hasham-qaiser hasham-qaiser linked a pull request Mar 18, 2024 that will close this issue
1236 good and bad examples aria labels #1265
Merged
@sydneywalcoff sydneywalcoff mentioned this issue Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hasham-qaiser hasham-qaiser

Labels
feature: accessibility front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person p-feature: advice https://expungeassist.org/advice priority: medium role: development anything related to code size: 1pt can be done in 6 hours or less
Projects
P: EA: Project Board
Status: Done
Milestone
Stakeholder Review
Development

Successfully merging a pull request may close this issue.

1236 good and bad examples aria labels hackforla/expunge-assist
Dev hackforla/expunge-assist
2 participants
@sydneywalcoff @hasham-qaiser