Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1236 good and bad examples aria labels #1265

Merged
merged 1 commit into from
Mar 25, 2024
Merged

1236 good and bad examples aria labels #1265

merged 1 commit into from
Mar 25, 2024

Conversation

hasham-qaiser
Copy link
Member

Fixes: #1236

Changes Made:

  • Added correct aria labels to each good and bad example listed on the Advice.tsx page.

Reason for changes:

  • To assist screen readers for each example, indicating which is a good example and which is a bad example.

@hasham-qaiser hasham-qaiser linked an issue Mar 18, 2024 that may be closed by this pull request
add labels to 'goods' and 'bad' examples #1236
Closed
1 task
@sydneywalcoff sydneywalcoff mentioned this pull request Mar 20, 2024
Open
sydneywalcoff
sydneywalcoff approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasham-qaiser This looks great! Thanks for making these changes!

@sydneywalcoff sydneywalcoff merged commit 01e9ad8 into dev Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneywalcoff sydneywalcoff sydneywalcoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add labels to 'goods' and 'bad' examples
2 participants
@hasham-qaiser @sydneywalcoff