Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color and typography style changes to target points not reached notification #1827

Closed
4 tasks done
Tracked by #1820
NilakshiS opened this issue Sep 5, 2024 · 1 comment · Fixed by #1884
Closed
4 tasks done
Tracked by #1820

Color and typography style changes to target points not reached notification #1827

NilakshiS opened this issue Sep 5, 2024 · 1 comment · Fixed by #1884
Assignees
Labels
level: easy p-feature: Final Summary Page pg 5 /calculation/5 pbv: dev All engineering issues priority: SHOULD HAVE role: front-end Front End Developer size: 0.5pt Can be done in 2-3 hours or less
Milestone

Comments

@NilakshiS
Copy link
Member

NilakshiS commented Sep 5, 2024

Overview

The notification for target points not reached on Page 5 uses a different font style and icon color than what's used in the current Design System, change the font styling and icon color to match the style guide.

Action Items

  • Remove the line break to align the text to a single line.
  • Remove the drop shadow from the text.
  • Change the font to "Subheading" style in the style guide.
  • Change warning icon color to "Warning (#E87D00)".

Resources/Instructions

Steps to reproduce this infobox

  1. Login to the dev site.
  2. Go to "Create Project" page.
  3. Enter some values for the required fields "Project Name", "Address" and "AIN" on Page 1.
  4. Click the forward button to go to the next page.
  5. Put the following values on Page 2:
    1. "Condominium Units": 1000
    2. "..... Enter Parking Spaces req'd": 1000
  6. Click the forward button to go to the next page.
  7. On Page 3 enter the value '50' for "Parking Provided"
  8. Click the forward button to go to the next page.
  9. Do not select anything on Page 4 and click the forward button to go to the next page.
  10. On Page 5, you should see the target points not reached on top.
Image for current target points not reached infobox

image

Link to Typography in the Style Guide
Link to Color Palette in the Style Guide
Link to Infoboxes in the Style Guide for more information

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Sep 5, 2024

@NilakshiS
Remove the ready for design lead, then:

  • if you are ready to have this prioritized, please add the ready for prioritization label.
  • If you are still working on this issue draft, add the draft label
  • If you have a question for product or dev or research, use the ready for dev lead, ready for product ready for research lead labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level: easy p-feature: Final Summary Page pg 5 /calculation/5 pbv: dev All engineering issues priority: SHOULD HAVE role: front-end Front End Developer size: 0.5pt Can be done in 2-3 hours or less
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

4 participants