You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can now construct any type definition through the actions API (sort of, see first bullet point). However, we still have several restrictions:
We cannot attach name hints to student-defined types. The backend outputs them but we just don't have actions for them. We may very well not want to expose this to students. But it is technically the one way in which we can have an ASTTypeDef value which cannot be constructed via the OpenAPI API. And we have discussed wanting to edit these in our frontend: Add tooltips to nodes in tree view primer-app#19.
We cannot re-order constructors, fields or parameters.
We cannot add constructors and fields at positions other than the end of the list.
We could, for example, offer "insert a constructor to the left" and "insert a constructor to the right" actions on existing constructors. This doesn't seem like great UX to me.
This is in a sense an instance of a more general problem. It's similar to how, for example, we can't choose which child the selected node becomes when inserting an application above it, or how we'd like to choose which field to "eta-expand" over. We may want a new API (and ultimately UI) for these sorts of interactions, e.g. a new kind of input action which takes an index.
I intend to open fresh issues for those points above which do not currently have one. There may in some cases still be relevant discussion in #267, e.g. on re-ordering.
The text was updated successfully, but these errors were encountered:
We can now construct any type definition through the actions API (sort of, see first bullet point). However, we still have several restrictions:
ASTTypeDef
value which cannot be constructed via the OpenAPI API. And we have discussed wanting to edit these in our frontend: Add tooltips to nodes in tree view primer-app#19.I intend to open fresh issues for those points above which do not currently have one. There may in some cases still be relevant discussion in #267, e.g. on re-ordering.
The text was updated successfully, but these errors were encountered: