Remove unnecessary Result type, replacing with isomorphic Either
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a no-brainer. |
dhess
approved these changes
Oct 21, 2021
|
(Although perhaps wait to merge this until after #180 is merged?) |
Yep, there will be a minor conflict, and it's probably marginally easier to rebase this one. |
|
OK, let's merge this one now? |
This is effectively a follow-up to hackworthltd/vonnegut#775. It wasn't noticed back then that somehow we had two workarounds for `Either` serialisation - `Data.Sum` *and* `App.Result`. There is a slight change to our encodings, since we were using `aeson`'s `defaultTaggedObject` sum encoding, whereas `Either`'s instance uses the more concise `ObjectWithSingleField`. See the changes to test fixtures.
georgefst
force-pushed
the
georgefst/result-to-either
branch
from
23f63c6
to
a32fa87
Compare
|
bors merge |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively a follow-up to https://github.com/hackworthltd/vonnegut/pull/775. It wasn't noticed back then that somehow we had two workarounds for
Eitherserialisation -Data.SumandApp.Result.There is a slight change to our encodings, since we were using
aeson'sdefaultTaggedObjectsum encoding, whereasEither's instance uses the more conciseObjectWithSingleField. See the changes to test fixtures.