Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases have SNAPSHOT strings in download link #149

Open
dstenger opened this issue Aug 13, 2024 · 4 comments · Fixed by #152
Open

Releases have SNAPSHOT strings in download link #149

dstenger opened this issue Aug 13, 2024 · 4 comments · Fixed by #152

Comments

@dstenger
Copy link

Releases >= version 5.2.0 listed here include SNAPSHOT strings in the download link.
Is this intentional?

@florianesser
Copy link
Member

florianesser commented Aug 13, 2024

Hi @dstenger, thanks for bringing this issue to our attention! The SNAPSHOT string in the file name of release artifacts is not intended, we will look into it.

Even worse: for the 5.2.1 release, the file name is also hale-5.3.0-SNAPSHOT.zip.

@stempler
Copy link
Member

My guess would be that this is caused by a dirty working copy of the Git repo during the release build. So we would need to identify what files cause that problem and probably add them to .gitignore.

@stempler
Copy link
Member

Looking at the action logs the version was determined correctly, but the issue was that the artifacts were built before the release was done. Should be fixed with the changes in #152

@stempler
Copy link
Member

Problem remains for existing releases - need to be updated.

@stempler stempler reopened this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants