-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use hale-core libraries and add formatting rules #153
Conversation
3f5ee2a
to
a9edb8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build works for me but when I try to use the output in a Gradle build with gradle-hale-plugin, I get the exception below.
I assume this needs to be fixed in hale-core, though.
Using hale-cli executable at /tmp/hale-5.4.0-SNAPSHOT/bin/hale
Adding system property user.timezone to command (gradle.properties)
(S) Loading hale project...
Exception in thread "main" java.lang.NoSuchMethodError: 'int org.osgi.framework.Version.compareTo(org.osgi.framework.Version)'
at eu.esdihumboldt.hale.common.core.io.project.impl.AbstractProjectReader.setProjectChecked(AbstractProjectReader.java:97)
at eu.esdihumboldt.hale.common.core.io.project.impl.DefaultProjectReader.execute(DefaultProjectReader.java:142)
at eu.esdihumboldt.hale.common.core.io.impl.AbstractIOProvider.execute(AbstractIOProvider.java:103)
at eu.esdihumboldt.hale.common.core.io.impl.AbstractImportProvider.execute(AbstractImportProvider.java:70)
at eu.esdihumboldt.hale.common.core.io.project.impl.ArchiveProjectReader.execute(ArchiveProjectReader.java:92)
at eu.esdihumboldt.hale.common.core.io.impl.AbstractIOProvider.execute(AbstractIOProvider.java:103)
at eu.esdihumboldt.hale.common.core.io.impl.AbstractImportProvider.execute(AbstractImportProvider.java:70)
at eu.esdihumboldt.hale.common.headless.HeadlessIO.executeProvider(HeadlessIO.java:208)
at eu.esdihumboldt.hale.common.headless.impl.ProjectTransformationEnvironment.<init>(ProjectTransformationEnvironment.java:198)
at eu.esdihumboldt.hale.app.transform.ExecTransformation.loadProject(ExecTransformation.java:286)
at eu.esdihumboldt.hale.app.transform.ExecTransformation.run(ExecTransformation.java:202)
at eu.esdihumboldt.hale.app.transform.ExecTransformation$run.call(Unknown Source)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
at eu.esdihumboldt.hale.app.transform.ExecApplication.run(ExecApplication.groovy:68)
at eu.esdihumboldt.hale.app.transform.ExecApplication.run(ExecApplication.groovy)
at eu.esdihumboldt.hale.common.app.AbstractApplication.run(AbstractApplication.java:48)
at eu.esdihumboldt.hale.common.app.AbstractApplication.start(AbstractApplication.java:30)
at eu.esdihumboldt.hale.common.app.ApplicationUtil.launchSyncApplication(ApplicationUtil.java:103)
at eu.esdihumboldt.hale.app.transform.TransformCommand.run(TransformCommand.groovy:32)
at eu.esdihumboldt.util.cli.impl.DelegatingCommand.run(DelegatingCommand.groovy:65)
at eu.esdihumboldt.util.cli.Runner.run(Runner.groovy:105)
at to.wetransform.halecli.CLI.main(CLI.java:30)
@florianesser Right now there seem to be three dependencies with the OSGi version class in hale-core:
But all of these seem to have the |
Running hale-cli with
Does |
Removing the |
...to test shadowed dependencies used in that library.
Import groovy packages first for Groovy sources.
Did some changes here to exclude/hide the OSGI dependencies in the SKOS library: halestudio/hale-core#55 Also added an integration test running a simple transformation (failed before, now succeeds) and a test that verifies the functionality of the modified SKOS I/O bundle. |
Nice solution! LGTM now |
🎉 This PR is included in version 6.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.