-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/ING-3911 #1033
feat/ING-3911 #1033
Conversation
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
de91b2d
to
8e68b12
Compare
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
8e68b12
to
58b31f1
Compare
retest this please |
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Show resolved
Hide resolved
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Show resolved
Hide resolved
From the test class the whenReadWithBufferedReader_thenCorrect() and testCPGFileCreation() have been removed and a new method testCpgFileAgainstRelatedSpapefile() called from all the Test methods. The writer has been updated taking the charset from the ShapefileDataStore of the related shapefile or adding the default charset in case the above one is null feat: extend shapefile writer to create .cpg file Create .cpg file/files when one/more .shp files are created. The .cpg file contain only the encoding used to write the shapefile. Create test for creating .cpg file
58b31f1
to
358e160
Compare
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
Create .cpg file/files when one/more .shp files are created. The .cpg file contain only the encoding used to write the shapefile. Create test for checking .cpg file content against related .shp file
@kapil-agnihotri Any idea related to the build failure? |
The error doesn't look like from our repositories but from groovy.jfrog.io artifactory. |
… into feat/ING-3911
Merge master into feat/ING-3911 to solve the problem of the build: change priority list of pluginRepositories
retest this please |
@emanuelaepure10 Advice on running unit tests in hale studio can be found here (sadly the "Run/debug as JUnit Plug-in test" in Eclipse often is quite slow to start depending on the Eclipse version, so there is an alternative described): |
fc98d6a
to
cf74501
Compare
@stempler I get 15 tests complete with success. |
...esdihumboldt.hale.io.shp/src/eu/esdihumboldt/hale/io/shp/writer/ShapefileInstanceWriter.java
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
...humboldt.hale.io.shp.test/src/eu/esdihumboldt/hale/io/shp/ShapefileInstanceWriterTest.groovy
Outdated
Show resolved
Hide resolved
Update test containing text with special characters Decode the encoded text containing special characters
cf74501
to
41297ed
Compare
* Update test and writer From the test class the whenReadWithBufferedReader_thenCorrect() and testCPGFileCreation() have been removed and a new method testCpgFileAgainstRelatedSpapefile() called from all the Test methods. The writer has been updated taking the charset from the ShapefileDataStore of the related shapefile or adding the default charset in case the above one is null feat: extend shapefile writer to create .cpg file Create .cpg file/files when one/more .shp files are created. The .cpg file contain only the encoding used to write the shapefile. Create test for creating .cpg file * feat: extend shapefile writer to create .cpg file Create .cpg file/files when one/more .shp files are created. The .cpg file contain only the encoding used to write the shapefile. Create test for checking .cpg file content against related .shp file * Set the charset to the writer as well as is done in the reader Update test containing text with special characters Decode the encoded text containing special characters
A new format .cpg has been added to the creatin of the .shp files.
The new files contains just the encoding text, such as “UTF-8”.
ING-3911