Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export transformed data leads to a shift of the attribute values #1062

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

emanuelaepure10
Copy link
Contributor

No shift in the attributes happens when exporting a transformed data to shp-file.

ING-4052

Copy link
Member

@stempler stempler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you can add a unit test that reproduces the original issue if that is easily done.

Please use fix: as prefix for the commit message instead of bug:. Thanks!

@emanuelaepure10 emanuelaepure10 changed the title bug: export transformed data leads to a shift of the attribute values fix: export transformed data leads to a shift of the attribute values Oct 4, 2023
@emanuelaepure10
Copy link
Contributor Author

I knew that you are going to ask about the test, but I actually wanted to ask you if you have idea how to have some/couple of instances out of all of the test that are not transformed.

What I mean is this
image
to have 13 instances of "arokstatus" in the source data and none in the transformed data.

Thank you

@stempler
Copy link
Member

stempler commented Oct 5, 2023

to have 13 instances of "arokstatus" in the source data and none in the transformed data.

I guess that is a matter of the transformation project used, which transformations functions are used there and if there are any errors during the transformation.

If this is about test data, it is probably easier to just create test data within the test, which is quite easy using the schema and instance builders, e.g. similar to here.

Were you able to identify what kind of data caused the issue?

Did it happen when

  • the first instance to write has null for an attribute value?
  • all instance have null for an attribute value?
  • any instance has null for an attribute value?

@emanuelaepure10
Copy link
Contributor Author

emanuelaepure10 commented Oct 5, 2023

The project doesn't have an error. It is intended to transform just a number of instances, not all.

The problem arise when in one instance a property has null value.

With all the projects I have tried the exported .shp file has been correctly exported after removing the check on the null value/property.

My question was about creating a test that would replicate the real case.
L.E: the test has been added. It's enough not to add all the properties to an instance.

… attribute values

No shift in the attributes happens when exporting a transformed data to shp-file.

ING-4052
@emanuelaepure10 emanuelaepure10 merged commit 3ec598b into halestudio:master Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants