Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable loading XSLX with blank rows and sheets for schema and source data #1065

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

emanuelaepure10
Copy link
Contributor

It is possible to load XLSX with multiple sheets that may contain blank sheets or rows or cells, both as source data and schema. Wizard: add the last 2 steps in one single step.

ING-4075

@emanuelaepure10 emanuelaepure10 force-pushed the fix/ING-4075 branch 2 times, most recently from 58fdb37 to 543cb1a Compare October 23, 2023 12:32
@emanuelaepure10
Copy link
Contributor Author

@florianesser Thank you very much for the comment
it's working indeed like that.
the only think is that you need to be careful to always have skip lines = 0, otherwise one can loose the first line.

@Kate-Lyndegaard for the example from the internal issue
image
we have 53 instances, as we expected.

My only fear is that
image
as you have same value for 3 different keywords(I don't know how to call them) from the schema,
image
and another value for all 3
image

you are also expecting to see it counted 3 times.

@emanuelaepure10
Copy link
Contributor Author

@florianesser @Kate-Lyndegaard

I have managed to give the value of the merged cells to all the cells from the merged area. Here is the result.

image
Please let me know if this is what you expected.

Thank you

@emanuelaepure10 emanuelaepure10 force-pushed the fix/ING-4075 branch 2 times, most recently from e9f1525 to 9b4e871 Compare November 13, 2023 09:11
Copy link
Member

@stempler stempler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emanuelaepure10 emanuelaepure10 requested review from florianesser and removed request for florianesser November 13, 2023 22:02
@florianesser
Copy link
Member

@emanuelaepure10 Please rebase the branch to get rid of the merge commit.

@emanuelaepure10
Copy link
Contributor Author

@florianesser done! Thank you for the feedback :-)

It is possible to load XLSX with multiple sheets that may contain blank pages or rows, as source data or schema.
Merged cells are giving the top-left value to all the cells in the merged area.
Wizard: add the last 2 steps in one single step.

ING-4075
Copy link
Member

@florianesser florianesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emanuelaepure10 emanuelaepure10 merged commit a3f4614 into halestudio:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants