-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable loading XSLX with blank rows and sheets for schema and source data #1065
fix: Enable loading XSLX with blank rows and sheets for schema and source data #1065
Conversation
io/plugins/eu.esdihumboldt.hale.io.xls/src/eu/esdihumboldt/hale/io/xls/XLSException.java
Outdated
Show resolved
Hide resolved
...ns/eu.esdihumboldt.hale.io.xls/src/eu/esdihumboldt/hale/io/xls/reader/XLSInstanceReader.java
Outdated
Show resolved
Hide resolved
...ns/eu.esdihumboldt.hale.io.xls/src/eu/esdihumboldt/hale/io/xls/reader/XLSInstanceReader.java
Outdated
Show resolved
Hide resolved
...lugins/eu.esdihumboldt.hale.io.xls/src/eu/esdihumboldt/hale/io/xls/AbstractAnalyseTable.java
Outdated
Show resolved
Hide resolved
...lugins/eu.esdihumboldt.hale.io.xls/src/eu/esdihumboldt/hale/io/xls/AbstractAnalyseTable.java
Outdated
Show resolved
Hide resolved
...ugins/eu.esdihumboldt.hale.io.xls/src/eu/esdihumboldt/hale/io/xls/AnalyseXLSSchemaTable.java
Show resolved
Hide resolved
...ins/eu.esdihumboldt.hale.io.xls.ui/src/eu/esdihumboldt/hale/io/xls/ui/XLSSchemaTypePage.java
Outdated
Show resolved
Hide resolved
58fdb37
to
543cb1a
Compare
...lugins/eu.esdihumboldt.hale.io.xls/src/eu/esdihumboldt/hale/io/xls/AbstractAnalyseTable.java
Outdated
Show resolved
Hide resolved
543cb1a
to
4c29a1f
Compare
4c29a1f
to
ec23ceb
Compare
@florianesser Thank you very much for the comment @Kate-Lyndegaard for the example from the internal issue My only fear is that you are also expecting to see it counted 3 times. |
@florianesser @Kate-Lyndegaard I have managed to give the value of the merged cells to all the cells from the merged area. Here is the result.
Thank you |
ec23ceb
to
d20fce9
Compare
...ugins/eu.esdihumboldt.hale.io.xls/src/eu/esdihumboldt/hale/io/xls/AnalyseXLSSchemaTable.java
Outdated
Show resolved
Hide resolved
e9f1525
to
9b4e871
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@emanuelaepure10 Please rebase the branch to get rid of the merge commit. |
d15c2cd
to
079f14a
Compare
@florianesser done! Thank you for the feedback :-) |
It is possible to load XLSX with multiple sheets that may contain blank pages or rows, as source data or schema. Merged cells are giving the top-left value to all the cells in the merged area. Wizard: add the last 2 steps in one single step. ING-4075
079f14a
to
f0594fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is possible to load XLSX with multiple sheets that may contain blank sheets or rows or cells, both as source data and schema. Wizard: add the last 2 steps in one single step.
ING-4075