feat: Update bundled resources/INSPIRE presets used in hale studio #1069

emanuelaepure10 · 2023-10-25T19:43:01Z

Update the location with the new updatesites https://gitlab.wetransform.to/hale/hale-build-support/commit/31200fbaed9428152f7886da3e0e11d5a9870974

ING-3236

stempler · 2023-10-26T07:08:01Z

@kapil-agnihotri Do you have any idea what the cause of the build failure is?
I thought maybe you saw something similar during the Java update?
https://builds.wetransform.to/job/hale/job/hale~pull/1532/console

kapil-agnihotri · 2023-10-26T11:45:48Z

Not sure about the root cause but it might be related to Tycho version.
Probably some updates in hale-platform impacted tycho and corrupted it.

We may try to update the Tycho version to the next one maybe?

@emanuelaepure10 does it also fails in your local system if you run ./build.sh clean ?

stempler · 2023-10-26T12:34:17Z

The build log can be quite confusing, since there are some errors that seem to be normal.
When comparing to a working build, this seems to be the actual problem:

> Task :buildProduct
Cannot resolve project dependencies:
  Software being installed: eu.esdihumboldt.hale.app.cli 5.1.0.qualifier
  Missing requirement: eu.esdihumboldt.hale.common.core 5.1.0.qualifier requires 'java.package; eu.esdihumboldt.hale.common.core.io.project.model.internal.generated 2.9.0' but it could not be found
  Cannot satisfy dependency: eu.esdihumboldt.hale.app.cli 5.1.0.qualifier depends on: java.package; eu.esdihumboldt.hale.common.core 0.0.0

stempler · 2023-10-26T12:43:16Z

requires 'java.package; eu.esdihumboldt.hale.common.core.io.project.model.internal.generated 2.9.0' but it could not be found

I looked at the related MANIFEST.MF - it seems to miss the version for the exported package:

Manifest-Version: 1.0
Bnd-LastModified: 1698149602738
Bundle-License: http://www.gnu.org/licenses/lgpl.html;description=Less
 er General Public License (LGPL) Version 3
Bundle-ManifestVersion: 2
Bundle-Name: HALE Project Format Model
Bundle-SymbolicName: eu.esdihumboldt.hale.common.core.io.project.model
 .jaxb
Bundle-Vendor: data harmonisation panel
Bundle-Version: 2.9.9
Export-Package: eu.esdihumboldt.hale.common.core.io.project.model.inte
 rnal.generated;uses:="jakarta.xml.bind,jakarta.xml.bind.annotation,ja
 vax.xml.datatype,org.w3c.dom"
Import-Package: javax.xml.datatype;resolution:=optional,javax.xml.name
 space;resolution:=optional,org.w3c.dom;resolution:=optional,jakarta.x
 ml.bind;resolution:=optional,jakarta.xml.bind.annotation;resolution:=
 optional
Originally-Created-By: 17.0.8.1 (Eclipse Adoptium)
Private-Package: eu.esdihumboldt.hale.common.core.io.project.model.int
 ernal.generated
Require-Bundle: org.glassfish.jaxb.runtime
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.7))"
Tool: Bnd-6.3.0.202206012108

Compared to that the Manifest for the previous version of the bundle:

Manifest-Version: 1.0
Bnd-LastModified: 1667374036662
Bundle-License: http://www.gnu.org/licenses/lgpl.html;description=Less
 er General Public License (LGPL) Version 3
Bundle-ManifestVersion: 2
Bundle-Name: HALE Project Format Model
Bundle-SymbolicName: eu.esdihumboldt.hale.common.core.io.project.model
 .jaxb
Bundle-Vendor: data harmonisation panel
Bundle-Version: 2.9.9
Export-Package: eu.esdihumboldt.hale.common.core.io.project.model.inte
 rnal.generated;version="2.9.9";uses:="jakarta.xml.bind,jakarta.xml.bi
 nd.annotation,javax.xml.datatype,org.w3c.dom"
Import-Package: javax.xml.datatype;resolution:=optional,javax.xml.name
 space;resolution:=optional,org.w3c.dom;resolution:=optional,jakarta.x
 ml.bind;resolution:=optional,jakarta.xml.bind.annotation;resolution:=
 optional
Originally-Created-By: 17 (Oracle Corporation)
Require-Bundle: org.glassfish.jaxb.runtime
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.7))"
Tool: Bnd-3.4.0.201707252008

This problem likely did not surface in Eclipse because the bundle version stayed the same and Eclipse may have used the old cached version.

stempler · 2023-10-26T13:11:21Z

@emanuelaepure10 You could try with the changes here: halestudio/hale-platform#51

When testing locally it added package exports to the JAXB bundles including the version as expected.

emanuelaepure10 · 2023-10-26T21:44:25Z

@kapil-agnihotri does it also fails in your local system if you run ./build.sh clean ?

Running the script locally I got a build successful.

emanuelaepure10 · 2023-10-27T08:05:51Z

@stempler I have used halestudio/hale-platform#51 to recreate the updatesite
I have even create PR with the version-history.json but Jenkins is still failing.
@kapil-agnihotri
Any idea how can I make it work?
thanks

stempler · 2023-10-27T09:00:36Z

Caused by: org.eclipse.tycho.p2.target.facade.TargetDefinitionResolutionException: Could not find "eu.esdihumboldt.hale.platform.feature.group/5.0.0.i20231025" in the repositories of the current location

@emanuelaepure10 It seems you only updated the commit sha in the target platform file, not the version of the platform feature.

emanuelaepure10 · 2023-10-27T09:49:10Z

@stempler By

not the version of the platform feature.

you mean this?

Does the PR need to be merged in order to be taken? As it is now doesn't work.

stempler · 2023-10-27T10:45:18Z

platform/hale-platform.target

-		<repository location="https://gitlab.wetransform.to/hale/hale-build-support/raw/d6435ab10b4a5cab971d1d7839c95b590542b662/updatesites/platform"/>
-		<unit id="eu.esdihumboldt.hale.platform.feature.group" version="4.1.0.i20230505"/>
+		<repository location="https://gitlab.wetransform.to/hale/hale-build-support/raw/e9436fa1b3c40b216f01daf20c3f21085e43b235/updatesites/platform"/>
+		<unit id="eu.esdihumboldt.hale.platform.feature.group" version="5.0.0.i20231025"/>


@emanuelaepure10 I mean this. My guess is you only updated the commit sha after the last change but not the version of the platform feature to reflect whatever version is present in that update site.

I see. somehow I forgot to push. I just did it now. Let's see the results :-)

Any idea how to solve this

Cannot resolve project dependencies: Software being installed: eu.esdihumboldt.hale.app.cli.commands 5.1.0.qualifier Missing requirement: eu.esdihumboldt.hale.common.align 5.1.0.qualifier requires 'osgi.bundle; com.vladsch.flexmark 0.64.0' but it could not be found Cannot satisfy dependency: eu.esdihumboldt.hale.app.cli.commands 5.1.0.qualifier depends on: osgi.bundle; eu.esdihumboldt.hale.common.align 2.9.5

The update site does not contain this bundle. See for instance the content of the related artifacts.jar (the XML file lists all plugins in the update site).

I guess you

Did the platform generation either w/o custom Eclipse home or w/o removing the old eclipse artifact (see last sentence on this comment)

Did not test the update site in Eclipse with hale studio or forgot to take measures that the new update site is used in Eclipse despite mostly no version changes on the bundles

After running the script to update hale-build-support ignored the deleted files and did not commit the deletions

@stempler I have probably missed this comment

In version 3 I changed the default eclipse artifact that is downloaded from the minimal eclipse product to a full Eclipse 2023-09. For this to be picked up you need to clear the folder .gradle/bnd-platform/ in your home directory.

I somehow don't have a .gradle/bnd-platform/ folder

Why I don't have it? What should I do to have it?

For this to be picked up you need to clear the folder .gradle/bnd-platform/ in your home directory.

In your home directory / user home.

In a *nix shell it would be the folder ~, if you use a Windows shell there seems to be a variable %USERPROFILE%

See https://en.wikipedia.org/wiki/Home_directory

@stempler @kapil-agnihotri
Please tell me what in this workflow is wrong or what is missing:

clean .gradle/bnd-platform/

move to master ``https://github.com/halestudio/hale-platform
2.1. change eclipseHome
2.1.0. I don't run ./gradlew -p modules/resources because it was done by @stempler in a previous PR merged into the master and for me this fails
2.2. run ./gradlew
2.3. run ./update-build-support.sh

create PR for hale-platform-update with the changes in updatesite

create PR for hale-platform with the version-history.json

in hale plugin platform
5.1. go to hale-platform.target update location repository with the commit from hale-platform-update.
5.2. reload locations and reload target platform
5.3. validate HALE.product
5.4. commit the changes
Thank you

change eclipseHome

This ideally should not be required, but as we found out with some Eclipse versions, including the one used by bnd-platform for some years, when running the update site creation there are bundles missing.
We changed the default artifact that is downloaded to one that works, but it does not automatically replace any previous downloaded artifact. Thus the cleanup in ~/.gradle/bnd-platform/.

run ./update-build-support.sh

Ideally before doing that test the update site within Eclipse using a file URL to the built update site in the file system. Eclipse has some caching mechanisms that can be hindering in such cases, so it is recommended to first rename the update site folder to something unique (e.g. append date and a counter).

After testing and then updating the build-support repo via the script, all changes in build-support should be added to the commit. If there are unexpected changes, e.g. bundles removed but not replaced or very many changes even though only a few are expected, something could be going wrong and it makes sense to check/investigate.

Update the location with the new updatesites https://gitlab.wetransform.to/hale/hale-build-support/commit/31200fbaed9428152f7886da3e0e11d5a9870974 to 10a1542203078a6afa14954ef0607e2f6b651544 ING-3236

stempler · 2023-10-28T20:02:39Z

Replaced by #1071

emanuelaepure10 requested review from stempler and kapil-agnihotri October 25, 2023 19:43

emanuelaepure10 force-pushed the feat/ING-3236 branch from 953a14e to 5dc8844 Compare October 26, 2023 20:28

stempler reviewed Oct 27, 2023

View reviewed changes

emanuelaepure10 force-pushed the feat/ING-3236 branch 2 times, most recently from 3ad4084 to 1c164a8 Compare October 27, 2023 13:36

feat: Update bundled resources/INSPIRE presets used in hale studio

b93cc05

Update the location with the new updatesites https://gitlab.wetransform.to/hale/hale-build-support/commit/31200fbaed9428152f7886da3e0e11d5a9870974 to 10a1542203078a6afa14954ef0607e2f6b651544 ING-3236

emanuelaepure10 force-pushed the feat/ING-3236 branch from 1c164a8 to b93cc05 Compare October 27, 2023 14:40

stempler closed this Oct 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update bundled resources/INSPIRE presets used in hale studio #1069

feat: Update bundled resources/INSPIRE presets used in hale studio #1069

emanuelaepure10 commented Oct 25, 2023

stempler commented Oct 26, 2023

kapil-agnihotri commented Oct 26, 2023

stempler commented Oct 26, 2023

stempler commented Oct 26, 2023

stempler commented Oct 26, 2023

emanuelaepure10 commented Oct 26, 2023

emanuelaepure10 commented Oct 27, 2023 •

edited

Loading

stempler commented Oct 27, 2023

emanuelaepure10 commented Oct 27, 2023 •

edited

Loading

stempler Oct 27, 2023

emanuelaepure10 Oct 27, 2023

emanuelaepure10 Oct 27, 2023

stempler Oct 27, 2023

emanuelaepure10 Oct 27, 2023

stempler Oct 27, 2023

emanuelaepure10 Oct 27, 2023

stempler Oct 28, 2023

stempler commented Oct 28, 2023

feat: Update bundled resources/INSPIRE presets used in hale studio #1069

feat: Update bundled resources/INSPIRE presets used in hale studio #1069

Conversation

emanuelaepure10 commented Oct 25, 2023

stempler commented Oct 26, 2023

kapil-agnihotri commented Oct 26, 2023

stempler commented Oct 26, 2023

stempler commented Oct 26, 2023

stempler commented Oct 26, 2023

emanuelaepure10 commented Oct 26, 2023

emanuelaepure10 commented Oct 27, 2023 • edited Loading

stempler commented Oct 27, 2023

emanuelaepure10 commented Oct 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stempler commented Oct 28, 2023

emanuelaepure10 commented Oct 27, 2023 •

edited

Loading

emanuelaepure10 commented Oct 27, 2023 •

edited

Loading