fix: fix provider definition for geometry.unifyWindingOrder parameters #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now the `providerParameter` definitions for the parameter `geometry.unifyWindingOrder` contained values that were inconsistent with the corresponding enumeration `EnumWindingOrderTypes`. Using the inconsistent values in CLI transformations could lead to unexpected results when using the value of the parameters given in the documentation that is derived from the `providerParameter` definitions.
florianesser
force-pushed
the
fix/provider-parameter-windingOrder
branch
from
f0071fd
to
a7b096c
Compare
stempler
approved these changes
May 21, 2024
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now the
providerParameterdefinitions for the parametergeometry.unifyWindingOrdercontained values that were inconsistent with the corresponding enumerationEnumWindingOrderTypes.Using the inconsistent values in CLI transformations could lead to unexpected results when using the value of the parameters given in the documentation that is derived from the
providerParameterdefinitions.