fix: use correct representation of date and time when exporting XML/GML #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuelaepure10
force-pushed
the
fix/date-time-conversion
branch
from
6907275
to
0ea075a
Compare
stempler
reviewed
Jul 1, 2024
emanuelaepure10
force-pushed
the
fix/date-time-conversion
branch
from
0ea075a
to
f2bc7e0
Compare
emanuelaepure10
changed the title
|
@emanuelaepure10 Thanks a lot for updating the commit message. I think that's already a lot better, but I think we can still improve it in a way that it is more meaningful to a user, e.g. make it clear what functionality is impacted. What do you think about this for example? |
Resolves issue introduced in 5.2.0 release. Conversion to XmlDate and XmlDateTime was done but the result not used.
emanuelaepure10
force-pushed
the
fix/date-time-conversion
branch
from
f2bc7e0
to
bde487f
Compare
emanuelaepure10
changed the title
|
@stempler I have updated the comment. |
stempler
approved these changes
Jul 3, 2024
stempler
added
the
challenged
|
🎉 This PR is included in version 5.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue introduced in 5.2.0 release.
Conversion to XmlDate and XmlDateTime was done but the result not used.