Revise pip.yml to produce true nightlies #7397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to produce new package(s) for every commit (which sometimes happens multiple times per day), it seems more reasonable (and less confusing) to produce nightlies instead. This PR is configured to trigger every night at 8:15 PST. Note that both the current status quo, and this PR, have a nontrivial defect that is hard to fix: they need to build against an LLVM image that we have in a Docker image; for release branches, that's a relatively fixed target, but for top-of-tree Halide, it really should be a working snapshot of top-of-tree LLVM. (At the time of this PR, Halide main should really have nightlies built against LLVM 17.x work-in-progress, but this PR builds against LLVM 15.0.7 because it's the most recent thing we have available. This is highly suboptimal.)
|
We probably want to go for every commit on release branches and for PRs to release branches. We also want to run the real deal when a release is created. |
Agreed. |
|
This has been sitting out here so long I forget where it stands. |
|
This has been superseded by #8405 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to produce new package(s) for every commit (which sometimes happens multiple times per day), it seems more reasonable (and less confusing) to produce nightlies instead. This PR is configured to trigger every night at 8:15 PST.
Note that both the current status quo, and this PR, have a nontrivial defect that is hard to fix: they need to build against an LLVM image that we have in a Docker image; for release branches, that's a relatively fixed target, but for top-of-tree Halide, it really should be a working snapshot of top-of-tree LLVM. (At the time of this PR, Halide main should really have nightlies built against LLVM 17.x work-in-progress, but this PR builds against LLVM 15.0.7 because it's the most recent thing we have available. This is highly suboptimal.)