fix: Terminate decode record early if one of its fields failed to decode #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered another edge-casey bug that is causing a panic:
runtime error: slice bounds out of range [4:1]
when decoding a record. This is because the record decoder doesn't terminate early when there's an error with its field.In the particular test cases provided, this line of code does not update
r.tail
, even thoughr.head
is updated. Thus, we have a scenario wherer.head
>r.tail
, which causes the slice bounds out of range error when decoding float.Unfortunately, after trying for an hour I haven't been able to minimize the test to a smaller test.