WalletDB Migration to v3 #889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodech
added
migrations
nodech
added a commit
to nodech/hsd
that referenced
this pull request
Mar 18, 2024
This requires full wdb block entry wipe and rescan. That is handled by PR handshake-org#889. `layout.h` is looked up by height, so only missing data was time. Now we can implement walletdb only median time past calculation.
nodech
added a commit
to nodech/hsd
that referenced
this pull request
Mar 18, 2024
This requires full wdb block entry wipe and rescan. That is handled by PR handshake-org#889. `layout.h` is looked up by height, so only missing data was time. Now we can implement walletdb only median time past calculation.
nodech
added a commit
to nodech/hsd
that referenced
this pull request
Aug 29, 2024
This requires full wdb block entry wipe and rescan. That is handled by PR handshake-org#889. `layout.h` is looked up by height, so only missing data was time. Now we can implement walletdb only median time past calculation.
|
Closing this. Proper migration is implemented in #888. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to WalletDB v3 is different from previous migrations. It does not try to reindex the old data into new layout, instead it drops most of it - allowing us to do heavier modifications. This migration removes all txdb mappings (except for blinds) and cleans up block entries received from the chain. This should trigger rescan from the genesis block.
Migration is separated from the actual txdb/walletdb changes in order to allow multiple PRs to modify the database and w/o it getting in the way. Migration needs to get merged last, before release of v7. This allows us to invalidate all commits between wdb v3 modifications and the migration. After migration there should no longer be any wdb modifications for wdb v3.
This PR currently tracks modifications: