From 92af9289d4ae25919ec4d83bf25262364340b29c Mon Sep 17 00:00:00 2001 From: Hanno Braun Date: Tue, 28 Nov 2023 17:59:10 +0100 Subject: [PATCH 1/2] Update module name --- crates/fj-core/src/operations/build/{edge.rs => half_edge.rs} | 0 crates/fj-core/src/operations/build/mod.rs | 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) rename crates/fj-core/src/operations/build/{edge.rs => half_edge.rs} (100%) diff --git a/crates/fj-core/src/operations/build/edge.rs b/crates/fj-core/src/operations/build/half_edge.rs similarity index 100% rename from crates/fj-core/src/operations/build/edge.rs rename to crates/fj-core/src/operations/build/half_edge.rs diff --git a/crates/fj-core/src/operations/build/mod.rs b/crates/fj-core/src/operations/build/mod.rs index af1334483..4f6a5b503 100644 --- a/crates/fj-core/src/operations/build/mod.rs +++ b/crates/fj-core/src/operations/build/mod.rs @@ -18,8 +18,8 @@ //! components. mod cycle; -mod edge; mod face; +mod half_edge; mod region; mod shell; mod sketch; @@ -28,8 +28,8 @@ mod surface; pub use self::{ cycle::BuildCycle, - edge::BuildHalfEdge, face::{BuildFace, Polygon}, + half_edge::BuildHalfEdge, region::BuildRegion, shell::{BuildShell, TetrahedronShell}, sketch::BuildSketch, From e5420f2b6e5bcad8be28d5d01dd83d5023201987 Mon Sep 17 00:00:00 2001 From: Hanno Braun Date: Tue, 28 Nov 2023 18:09:02 +0100 Subject: [PATCH 2/2] Fix `UpdateShell::remove_face` --- crates/fj-core/src/operations/update/shell.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/fj-core/src/operations/update/shell.rs b/crates/fj-core/src/operations/update/shell.rs index e39fa92a5..7b19737ee 100644 --- a/crates/fj-core/src/operations/update/shell.rs +++ b/crates/fj-core/src/operations/update/shell.rs @@ -79,7 +79,7 @@ impl UpdateShell for Shell { let faces = self .faces() .iter() - .filter(|face| face.id() == handle.id()) + .filter(|face| face.id() != handle.id()) .cloned(); Shell::new(faces)