Skip to content

Commit

Permalink
cleanup, remove todos
Browse files Browse the repository at this point in the history
  • Loading branch information
nathan-folsom committed Jan 14, 2024
1 parent b698a0b commit 5e885a4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
8 changes: 0 additions & 8 deletions crates/fj-core/src/validate/sketch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ impl Validate for Sketch {
/// [`Sketch`] validation failed
#[derive(Clone, Debug, thiserror::Error)]
pub enum SketchValidationError {
/// [`HalfEdge`] referenced by more than one [`Cycle`]
#[error("[`HalfEdge`] referenced by more than one [`Cycle`]")]
HalfEdgeMultipleReferences,
/// [`Cycle`] referenced by more than one [`crate::objects::Region`]
#[error("[`Cycle`] referenced by more than one [`Region`]")]
CycleMultipleReferences,
/// Object within sketch referenced by more than one other object
#[error("Object within sketch referenced by more than one other Object")]
MultipleReferences(#[from] ReferenceCountError),
Expand All @@ -35,8 +29,6 @@ impl SketchValidationError {
_config: &ValidationConfig,
errors: &mut Vec<ValidationError>,
) {
// todo: store referencing objects instead of just a reference count so that we can surface
// them in the error message
let mut referenced_edges = ReferenceCounter::new();
let mut referenced_cycles = ReferenceCounter::new();

Expand Down
2 changes: 0 additions & 2 deletions crates/fj-core/src/validate/solid.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,6 @@ impl SolidValidationError {
_config: &ValidationConfig,
errors: &mut Vec<ValidationError>,
) {
// todo: store referencing objects instead of just a reference count so that we can surface
// them in the error message
let mut referenced_regions = ReferenceCounter::new();
let mut referenced_faces = ReferenceCounter::new();
let mut referenced_edges = ReferenceCounter::new();
Expand Down

0 comments on commit 5e885a4

Please sign in to comment.