Skip to content

Commit

Permalink
Merge pull request #2147 from hannobraun/cleanup
Browse files Browse the repository at this point in the history
Make some minor clean-ups in `fj-core`
  • Loading branch information
hannobraun authored Dec 21, 2023
2 parents 699b499 + 6d3c78b commit cf77d92
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
File renamed without changes.
2 changes: 1 addition & 1 deletion crates/fj-core/src/objects/kinds/mod.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pub mod curve;
pub mod cycle;
pub mod edge;
pub mod face;
pub mod half_edge;
pub mod region;
pub mod shell;
pub mod sketch;
Expand Down
2 changes: 1 addition & 1 deletion crates/fj-core/src/objects/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ pub use self::{
kinds::{
curve::Curve,
cycle::Cycle,
edge::HalfEdge,
face::{Face, Handedness},
half_edge::HalfEdge,
region::Region,
shell::Shell,
sketch::Sketch,
Expand Down
8 changes: 4 additions & 4 deletions crates/fj-core/src/operations/update/cycle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pub trait UpdateCycle {
#[must_use]
fn add_half_edges(
&self,
edges: impl IntoIterator<Item = Handle<HalfEdge>>,
half_edges: impl IntoIterator<Item = Handle<HalfEdge>>,
) -> Self;

/// Update an edge of the cycle
Expand Down Expand Up @@ -47,10 +47,10 @@ pub trait UpdateCycle {
impl UpdateCycle for Cycle {
fn add_half_edges(
&self,
edges: impl IntoIterator<Item = Handle<HalfEdge>>,
half_edges: impl IntoIterator<Item = Handle<HalfEdge>>,
) -> Self {
let edges = self.half_edges().iter().cloned().chain(edges);
Cycle::new(edges)
let half_edges = self.half_edges().iter().cloned().chain(half_edges);
Cycle::new(half_edges)
}

fn update_half_edge(
Expand Down

0 comments on commit cf77d92

Please sign in to comment.