Merge pull request #2393 from hannobraun/surface

Add `BuildSurface::from_geometry`

crates/fj-core/src/operations/build/surface.rs

@@ -14,6 +14,35 @@ use crate::{
 ///
 /// [module-level documentation]: super
 pub trait BuildSurface {
+    /// Build a surface from the provided geometry
+    fn from_geometry(
+        surface_geom: SurfaceGeom,
+        core: &mut Core,
+    ) -> Handle<Surface> {
+        let surface = Surface::new().insert(core);
+
+        core.layers
+            .geometry
+            .define_surface(surface.clone(), surface_geom);
+
+        surface
+    }
+
+    /// Build a surface from the provided `u` and `v`
+    fn from_uv(
+        u: impl Into<GlobalPath>,
+        v: impl Into<Vector<3>>,
+        core: &mut Core,
+    ) -> Handle<Surface> {
+        Self::from_geometry(
+            SurfaceGeom {
+                u: u.into(),
+                v: v.into(),
+            },
+            core,
+        )
+    }
+
     /// Build a plane from the provided points
     fn plane_from_points(
         points: [impl Into<Point<3>>; 3],
@@ -36,25 +65,6 @@ pub trait BuildSurface {
 
         (surface, points_surface)
     }
-
-    /// Build a plane from the provided `u` and `v`
-    fn from_uv(
-        u: impl Into<GlobalPath>,
-        v: impl Into<Vector<3>>,
-        core: &mut Core,
-    ) -> Handle<Surface> {
-        let surface = Surface::new().insert(core);
-
-        core.layers.geometry.define_surface(
-            surface.clone(),
-            SurfaceGeom {
-                u: u.into(),
-                v: v.into(),
-            },
-        );
-
-        surface
-    }
 }
 
 impl BuildSurface for Surface {}