Skip to content

Commit

Permalink
Explain big side-face loop in face sweep code
Browse files Browse the repository at this point in the history
  • Loading branch information
hannobraun committed Nov 16, 2023
1 parent 9abb132 commit d9d7bc8
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions crates/fj-core/src/algorithms/sweep/face.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ impl Sweep for Handle<Face> {
let mut top_exterior = None;
let mut top_interiors = Vec::new();

// This might not be the cleanest way to do it, but here we're creating
// the side faces, and all the ingredients for the top face, in one big
// loop. Reason is, the side faces need to be connected to the top face,
// and this seems like the most straight-forward way to make sure of
// that.
for (i, bottom_cycle) in bottom_face.region().all_cycles().enumerate() {
let bottom_cycle = bottom_cycle.reverse(services);

Expand Down

0 comments on commit d9d7bc8

Please sign in to comment.