Skip to content

Commit

Permalink
Don't specify unused render pass stuff
Browse files Browse the repository at this point in the history
This should make this code more robust in the face of future additions
to this struct.
  • Loading branch information
hannobraun committed Oct 30, 2023
1 parent 93907f1 commit e117047
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion crates/fj-viewer/src/graphics/navigation_cube.rs
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ impl NavigationCubeRenderer {
store: true,
},
})],
depth_stencil_attachment: None,
..Default::default()
});
render_pass.set_pipeline(&self.render_pipeline);
render_pass.set_bind_group(1, &self.mvp_matrix_bind_group, &[]);
Expand Down
2 changes: 1 addition & 1 deletion crates/fj-viewer/src/graphics/renderer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ impl Renderer {
{
let mut render_pass =
encoder.begin_render_pass(&wgpu::RenderPassDescriptor {
label: None,
color_attachments: &[Some(
wgpu::RenderPassColorAttachment {
view: &self.frame_buffer,
Expand All @@ -295,6 +294,7 @@ impl Renderer {
stencil_ops: None,
},
),
..Default::default()
});
render_pass.set_bind_group(0, &self.bind_group, &[]);

Expand Down

0 comments on commit e117047

Please sign in to comment.