Validate winding of sketches #2158
Labels
good first issue
Good for newcomers
topic: validation
Infrastructure for checking various properties of objects, making sure they are valid.
type: feature
New features and improvements to existing features
Sketch
es each contain multipleRegion
s. The exterior cycle of those regions should have counter-clockwise winding, their interior cycles should have clockwise winding. I believe that the sweep code already assumes this, but currently, this is not documented nor enforced.Implementation
This new validation check would go into the
validate
module, specificallyvalidate::sketch
. You can use the structure of the existing validation check (forSketch
and other objects) as a guideline for the implementation.The check itself should be rather straight-forward, as it could just use
Cycle::winding
. Please note that this method is buggy (#2130), but as long as we make sure not to use any complicated cycles in the unit test for this validation check, we'll be fine (just stick to polygons).Since this should be relatively straight-forward, and there are already numerous validation checks to serve as inspiration, I'm designating this as a good first issueGood for newcomers
.
Related Issues
There are two related issues:
Neither of those issues are blockers for this one, but work would need to be coordinated. If you're interested in picking this up, I suggest you check out those issues to see if anybody is already working on them.
The text was updated successfully, but these errors were encountered: