Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that half-edges in a cycle don't intersect #2159

Open
hannobraun opened this issue Jan 16, 2024 · 0 comments
Open

Validate that half-edges in a cycle don't intersect #2159

hannobraun opened this issue Jan 16, 2024 · 0 comments
Labels
topic: validation Infrastructure for checking various properties of objects, making sure they are valid. type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

hannobraun commented Jan 16, 2024

About

Half-edges in a cycle must not intersect, if the shape that contains the cycle is to be valid. This is currently neither documented nor enforced.

There should be a validation check on the cycle level that makes sure that none of the half-edges with the cycles intersect.

Implementation

The new validation check should go into validate::cycle the existing check there (and the numerous checks in the sibling modules) can be used as inspiration on how to implement it.

Related Issues

There are a few related issues currently open:

None of those other issues are blockers, but in case work on them is ongoing by the time this issue is picked up, this would require coordination of the work.

@hannobraun hannobraun added type: feature New features and improvements to existing features topic: validation Infrastructure for checking various properties of objects, making sure they are valid. labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: validation Infrastructure for checking various properties of objects, making sure they are valid. type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant