New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove out-of-date note #1954

Merged

hannobraun merged 1 commit into hannobraun:main from A-Walrus:remove_note

Jul 22, 2023

Contributor

A-Walrus commented Jul 21, 2023

We do validate that a shell is watertight, see: https://github.com/hannobraun/fornjot/blob/40b364814a6f9f0c85f508e637941ee0cc2bd0eb/crates/fj-core/src/validate/shell.rs#L24C40-L24C40


          Remove out-of-date note

76d73f8

We do validate that a shell is watertight

A-Walrus requested a review from hannobraun as a code owner

July 21, 2023 14:14

hannobraun approved these changes

View reviewed changes

Owner

hannobraun left a comment

Thank you, @A-Walrus, good catch!

hannobraun merged commit 2b0ec2e into hannobraun:main

4 checks passed

A-Walrus deleted the remove_note branch

September 25, 2023 10:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet