Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate validation check for coincident half-edges that are not siblings to new validation infrastructure #2362

Merged
merged 20 commits into from
May 22, 2024
Merged

Migrate validation check for coincident half-edges that are not siblings to new validation infrastructure #2362

merged 20 commits into from
May 22, 2024

Commits on May 22, 2024

  1. Make module name more specific 

    I need to add another module there that could basically have the same
name.
    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ce6b402 View commit details
    Browse the repository at this point in the history

  2. Add CoincidentHalfEdgesAreNotSiblings

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e47c267 View commit details
    Browse the repository at this point in the history

  3. Refactor to prepare for follow-on change

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2efce53 View commit details
    Browse the repository at this point in the history

  4. Refactor to prepare for follow-on change

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    fdb2830 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary Boxes

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4dd9216 View commit details
    Browse the repository at this point in the history

  6. Inline redundant struct

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    de90327 View commit details
    Browse the repository at this point in the history

  7. Inline redundant struct

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f08f91f View commit details
    Browse the repository at this point in the history

  8. Inline redundant struct

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8f7ee90 View commit details
    Browse the repository at this point in the history

  9. Refactor to increase consistency

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c73ea02 View commit details
    Browse the repository at this point in the history

  10. Document CoincidentHalfEdgesAreNotSiblings

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8c334a9 View commit details
    Browse the repository at this point in the history

  11. Move CoincidentHalfEdgesAreNotSiblings 

    Move it to the module for the new validation infrastructure.
    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c55af6c View commit details
    Browse the repository at this point in the history

  12. Refactor to prepare for follow-on change

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2711e4c View commit details
    Browse the repository at this point in the history

  13. Refactor to prepare for follow-on change

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d63f88c View commit details
    Browse the repository at this point in the history

  14. Refactor to prepare for follow-on change

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2d104db View commit details
    Browse the repository at this point in the history

  15. Move validation error variant to ValidationError

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    14020aa View commit details
    Browse the repository at this point in the history

  16. Rename argument to prepare for follow-on change

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    82c36df View commit details
    Browse the repository at this point in the history

  17. Implement ValidationCheck for check

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1bd5fc7 View commit details
    Browse the repository at this point in the history

  18. Remove redundant code

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    907b9e3 View commit details
    Browse the repository at this point in the history

  19. Move test closer to code under test

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    17ad40b View commit details
    Browse the repository at this point in the history

  20. Refactor to increase consistency

    @hannobraun
    hannobraun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cf3c97f View commit details
    Browse the repository at this point in the history