Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests for "multiple references" checks #2390

Merged
merged 1 commit into from
Jun 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions crates/fj-core/src/validation/checks/multiple_references.rs
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,22 @@ impl<T, U> ReferenceCounter<T, U> {
}
}

// I (@hannobraun) have disabled all the tests in here. It has turned out to be
// difficult, maybe impossible, to construct geometry which triggers the
// validation check, but isn't either invalid or otherwise very problematic in
// other ways. This has caused issues in the work on [#2290].
//
// Specifically, this caused problem in transitioning multiple other validation
// checks, due to geometry not being defined into all contexts, which was
// triggered by (and only by) these tests. Since the redundant definition of
// geometry is (hopefully) about to go away (which #2290 contributes to), I
// don't think it is worth it to go through a lot of trouble to address this in
// a way that keeps these tests active.
//
// Once geometry is no longer defined redundantly, we can revisit this and try
// to re-enable these tests.
//
// [#2290]: https://github.com/hannobraun/fornjot/issues/2290
#[cfg(test)]
mod tests {
use crate::{
Expand All @@ -192,6 +208,7 @@ mod tests {
};

#[test]
#[ignore]
fn multiple_references_to_cycle_within_sketch() -> anyhow::Result<()> {
let mut core = Core::new();

Expand Down Expand Up @@ -220,6 +237,7 @@ mod tests {
}

#[test]
#[ignore]
fn multiple_references_to_half_edge_within_sketch() -> anyhow::Result<()> {
let mut core = Core::new();

Expand Down Expand Up @@ -259,6 +277,7 @@ mod tests {
}

#[test]
#[ignore]
fn multiple_references_to_face_within_solid() -> anyhow::Result<()> {
let mut core = Core::new();

Expand Down Expand Up @@ -307,6 +326,7 @@ mod tests {
}

#[test]
#[ignore]
fn multiple_references_to_region_within_solid() -> anyhow::Result<()> {
let mut core = Core::new();

Expand Down Expand Up @@ -355,6 +375,7 @@ mod tests {
}

#[test]
#[ignore]
fn multiple_references_to_cycle_within_solid() -> anyhow::Result<()> {
let mut core = Core::new();

Expand Down Expand Up @@ -414,6 +435,7 @@ mod tests {
}

#[test]
#[ignore]
fn multiple_references_to_half_edge_within_solid() -> anyhow::Result<()> {
let mut core = Core::new();

Expand Down