Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage FhirRequestBuilders via ManagedWebAccess #1788

Merged
merged 49 commits into from
Nov 8, 2024
Merged

Conversation

dotasek
Copy link
Collaborator

@dotasek dotasek commented Oct 25, 2024

Rework ManagedWebAccess and the various FhirRequestBuilders to ensure the following:

  • FhirRequestBuilders and SimpleHTTPClient should always use ManagedWebAccess to:
    • Set the 'User-Agent'
    • Set appropriate 'Authorization' or 'Api-Key' headers

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.73%. Comparing base (6775a09) to head (765ba8b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1788      +/-   ##
============================================
+ Coverage     12.71%   12.73%   +0.02%     
- Complexity    32947    33028      +81     
============================================
  Files          2211     2218       +7     
  Lines        675662   675849     +187     
  Branches     199169   199208      +39     
============================================
+ Hits          85881    86059     +178     
+ Misses       559303   559294       -9     
- Partials      30478    30496      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotasek dotasek marked this pull request as ready for review November 8, 2024 20:53
@dotasek
Copy link
Collaborator Author

dotasek commented Nov 8, 2024

Merging after Zulip confirmation from @grahamegrieve

@dotasek dotasek merged commit 59fe0c6 into master Nov 8, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants