Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 add and improve typings from DT #126

Merged
merged 1 commit into from
Aug 4, 2023
Merged

feat: 🎸 add and improve typings from DT #126

merged 1 commit into from
Aug 4, 2023

Conversation

damusix
Copy link
Contributor

@damusix damusix commented May 27, 2023

No description provided.

Marsup
Marsup requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@Marsup Marsup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you probably need to add typescript, node types, and -Y to lab's commands to test types.

@Marsup Marsup added this to the 7.0.2 milestone Aug 4, 2023
@Marsup Marsup added the types TypeScript type definitions label Aug 4, 2023
@Marsup Marsup self-assigned this Aug 4, 2023
@Marsup Marsup merged commit 2888daa into hapijs:master Aug 4, 2023
Marsup added a commit that referenced this pull request Aug 4, 2023
@Marsup
chore: enable lab type tests
ef7fad5 
Follow-up to #126.
@Marsup Marsup mentioned this pull request Aug 4, 2023
Merged
Marsup added a commit that referenced this pull request Aug 4, 2023
@Marsup
chore: enable lab type tests
f8bfbec 
Follow-up to #126.
Marsup added a commit that referenced this pull request Aug 4, 2023
@Marsup
chore: enable lab type tests
b381647 
Follow-up to #126.
@Marsup
Copy link
Contributor

Marsup commented Aug 4, 2023

@damusix #128 is what I meant regarding the previous comment, the tests were not executed at all. Thanks a lot for this PR!

Marsup added a commit that referenced this pull request Aug 4, 2023
@Marsup
chore: enable lab type tests (#128)
727f88d 
Follow-up to #126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marsup Marsup Marsup requested changes

Assignees

@Marsup Marsup

Labels
types TypeScript type definitions
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@damusix @Marsup