-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support encoding uri #3027
Conversation
Looks like you also need to test for |
@Marsup Thanks for the review! I will add a test case for |
Just missing a quick description in Lines 3084 to 3089 in 5b96852
|
Sorry for the delay. Just updated the PR! |
I'll change it a bit before releasing for some edge cases, but this is good to go, thanks! |
Thanks, @Marsup! Please close the issue as well. I don't have a permission to do that because I'm not the one who opened it. |
It's published. |
Related Issue
About Changes
encodeUri
with defaultfalse
inUriOptions
.encodeUri
in string validation method.convert
andencodeUri
flags aretrue
.Result