Optimize header toLowerCasing #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanongil
force-pushed
the
less-lowercasing
branch
from
1eec667 to
c91240a
Compare
kanongil
force-pushed
the
less-lowercasing
branch
from
c91240a to
c226d9a
Compare
devinivy
approved these changes
Apr 3, 2024
jonathansamines
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All requests currently include a number of calls to string
toLowerCase()on header names. Especially if there are any user provided headers, where each provided header name is lowercased at 2 - 4 times.This PR removes the need to lowercase when no headers are provided, and reduces it to a single time for each name when they are provided.
Additionally, this also fixes redundant lowercasing in
read()where incoming headers would be lowercased, even though they already were by node.This is a pure refactor, and should have no effect** other than requiring slightly less CPU/memory usage, while being easier to read.
** The behaviour is actually changed for
''values forhostandcontent-type, where they are now considered set. Also for headers with "duplicate" entries, eg.{ host: undefined, HOST: 'hello' }, which will detect it as set, where the old logic would not.