Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hb_version symbol and .version member #102

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Add hb_version symbol and .version member #102

merged 2 commits into from
Aug 29, 2024

Conversation

simoncozens
Copy link
Collaborator

This patch allows hbjs.version to return (as a string) the version number of Harfbuzz being used.

khaledhosny
khaledhosny reviewed Aug 29, 2024
View reviewed changes
hbjs.js Outdated Show resolved Hide resolved
@khaledhosny khaledhosny merged commit 678ddbc into main Aug 29, 2024
1 check passed
@khaledhosny khaledhosny deleted the add-hbversion branch August 29, 2024 12:17
@simoncozens
Copy link
Collaborator Author

Now you don't need the _hb_version import.

@khaledhosny
Copy link
Contributor

Now you don't need the _hb_version import.

I’m wondering, should we instead add both .version that returns a list of numbers (or a dictionary) and .version_string that is the current one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaledhosny khaledhosny khaledhosny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simoncozens @khaledhosny