Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cactuar needs to generate HTTP alerts #31

Open
harrytucker opened this issue Mar 2, 2023 · 0 comments
Open

Cactuar needs to generate HTTP alerts #31

harrytucker opened this issue Mar 2, 2023 · 0 comments
Assignees
@harrytucker
Labels
enhancement New feature or request

Comments

@harrytucker
Copy link
Owner

harrytucker commented Mar 2, 2023 •
edited
Loading

To generate HTTP alerts, Cactuar needs to be extended in two places:

  1. src/prometheus/alert.rs: TryFrom implementation needs an if let Some(...) block added to check for HTTP alerts
  2. src/prometheus/http_alerts.rs: New functions need to be added here to generate the PromQL and annotations to go with them. This can follow the same structure as replica_alerts.rs which is implemented within the same module.

Once done, this can be verified by creating a ServiceAlert CRD in your cluster with the controller running that asks for a HTTP alert to be created. If everything is implemented correctly, the ConfigMap generated by the controller should include the generated PromQL for the HTTP alerts as a new alert group.
@harrytucker harrytucker added the enhancement New feature or request label Mar 2, 2023
@harrytucker harrytucker self-assigned this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrytucker harrytucker

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harrytucker