bug fix found in testing

harvard-ufds · Feb 13, 2024 · f07940d · f07940d
1 parent 2297cfd
commit f07940d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/.github/workflows/test-coverage.yaml b/.github/workflows/test-coverage.yaml
@@ -25,6 +25,14 @@ jobs:
         with:
           extra-packages: any::covr
           needs: coverage
+
+      - name: Set CRAN mirror
+        run: echo "options(repos = c(CRAN='https://cloud.r-project.org/'))" > ~/.Rprofile
+
+      - name: Install problem dependency
+        run: |
+          install.packages('lme4', type = 'source')
+        shell: Rscript {0}
 
       - name: Test coverage
         run: |

diff --git a/R/utils.R b/R/utils.R
@@ -97,8 +97,8 @@ generate_mse <- function(.data,
 
   design_mat_ls <-  boot_pop_by_dom |> 
     map(.f = function(.x) {
-      dmat_lm <- model.matrix(~., .x[ ,lin_X])
-      dmat_glm <- model.matrix(~., .x[ ,log_X])
+      dmat_lm <- model.matrix(~., .x[ ,lin_X, drop = FALSE])
+      dmat_glm <- model.matrix(~., .x[ ,log_X, drop = FALSE])
       return(list(design_mat_lm = dmat_lm,
                   design_mat_glm = dmat_glm))
     })

diff --git a/tests/testthat/test-saeczi.R b/tests/testthat/test-saeczi.R
@@ -1,7 +1,11 @@
 data(pop)
 data(samp)
 
-lin_formula <- DRYBIO_AG_TPA_live_ADJ ~ tcc16 + elev
+lin_formula <- sqrtbio ~ tcc16 
+
+samp <- samp |> 
+  mutate(sqrtbio = sqrt(DRYBIO_AG_TPA_live_ADJ))
+
 
 set.seed(5)
 result <- saeczi(samp,
@@ -16,8 +20,6 @@ test_that("result$res is a df", {
   expect_s3_class(result$res, "data.frame")
 })
 
-
-
 test_that("correct number of rows in result data.frame", {
   expect_equal(nrow(result$res), length(unique(pop$COUNTYFIPS)))
 })