Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbatches vs batch_size #103

Open
thomasahle opened this issue Nov 21, 2022 · 0 comments
Open

nbatches vs batch_size #103

thomasahle opened this issue Nov 21, 2022 · 0 comments

Comments

@thomasahle
Copy link

In the forward method you currently say nbatches = query.size(0), but this appears to actually be the batch size, not the total number of batches the network is trained for.

I don't know if some people use this nomenclature differently, but I think renaming the variable to batch_size would be a bit more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant