The first column of synthetic data in the first example should be set to 0 instead of 1?

[alaneuler]

Skimmed through old version of "annotated-transformer" the start_symbol is 1:

but changed to 0 afterwards. Should the code in method data_gen also be changed to 0 for consistence?

[rocinant]

I get same question here.

[rocinant]

i tried both, change data[:, 0] = 1 to data[:, 0] = 0 should be right.

Skimmed through old version of "annotated-transformer" the start_symbol is 1: but changed to 0 afterwards. Should the code in method data_gen also be changed to 0 for consistence?