Python3 Preprocessing and UTF-8 decoding of GoogleNews-vectors correction #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargrohin
commented
Jan 26, 2020
| word = [] | ||
| while True: | ||
| ch = f.read(1) | ||
| try: | ||
| ch = f.read(1).decode("utf-8") |
There was a problem hiding this comment.
This line was not working without .decode("utf-8") for certain lines in GoogleNews-vector-bin. Needed try-exceptbecause of some bad end of line characters in GoogleNews-vector-bin`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
preprocess.pyto Python3. Corrected reading of characters fromGoogleNews-vectors-negative300.binby adding.decode("utf-8"), which was not working before, at least in Python3. Tested on custom datasets.