-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move builder and cleanup #1
Conversation
c5d2062
to
203b500
Compare
918e0bb
to
a380585
Compare
Just did a build locally:
The repository name should be rancher. |
- Also, bump golang v1.22 - fix the complain from complier Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
a380585
to
154ba73
Compare
EIO ticket: https://github.com/rancherlabs/eio/issues/2361 |
154ba73
to
9e65a6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, just a couple of small things below.
Also, main.go line 82 specifies this:
driverName = flag.String("drivername", "lvm.csi.metal-stack.io", "name of the driver")
I know we set this to lvm.driver.harvesterhci.io
in deploy/charts/values.yaml
,
but should we also change the default in main.go as this is our fork? And, if we do change the default, maybe we don't need to specify it in the chart values?
- Also, update the driver default name Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
- We sometimes will stuck on the lvcreate due lacking the udev operations. But actually lvm can handle the device well. So we involve the host-side lvm config and skip the udev_sync and udev_rules. Give the lvm handle the whole things. Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
9e65a6d
to
6778ed4
Compare
- Also, remove the redundant GHA Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
6778ed4
to
14707c2
Compare
Nice catch, driverName updated! |
TODO ITEM
GOOD TO HAVE