Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] fix terraform fixture bug #1507

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[e2e] fix terraform fixture bug #1507

merged 1 commit into from
Sep 11, 2024

Conversation

lanfon72
Copy link
Member

@lanfon72 lanfon72 commented Sep 5, 2024

Changes

  • UPDATE terraform fixture to fix bug when using 0.0.0-dev

@lanfon72
Copy link
Member Author

lanfon72 commented Sep 5, 2024

Tested on harvester-runtests#101
image

Those fail cases caused by the ISO server which is unavailable now.

@lanfon72 lanfon72 requested review from albinsun and a team September 5, 2024 18:06
irishgordo
irishgordo requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@irishgordo irishgordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a small qu 😄 - non-blocking

harvester_e2e_tests/fixtures/terraform.py Show resolved Hide resolved
albinsun
albinsun approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irishgordo
Copy link
Contributor

LGTM

@lanfon72 lanfon72 merged commit ff58cd8 into harvester:main Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinsun albinsun albinsun approved these changes

@irishgordo irishgordo irishgordo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanfon72 @irishgordo @albinsun