Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual] Add manual test plan for vm-import with EFI mode and secure boot #1518

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

TachunLin
Copy link
Contributor

@TachunLin TachunLin commented Sep 10, 2024

What this PR does / why we need it:

This PR is used to add manual test plan according to the latest vm-import-controller enhancement issue
harvester/harvester#5846

Test Scenarios

  • For OpenStack:

    • BIOS based VM Migration
    • EFI Based VM Migration
    • EFI Based VM with secure boot migration:
    • Using a custom storage class
  • For VMware:

    • BIOS based VM Migration
    • EFI Based VM Migration
    • EFI Based VM with secure boot migration:
    • Using a custom storage class

Special notes for your reviewer:

Tested on the local hugo server, image can be loaded well.

Additional documentation or context

Related task ticket:
#1509

1. Get the available access to the existing or prepared vSphere client (v7.1)

## Harvester Prerequisite Setup
1. Harvester can connect to the OpenStack dashbord and API endpoint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, dashboard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the check. Update the typos to dashboard.


## Harvester Prerequisite Setup
1. Harvester can connect to the OpenStack dashbord and API endpoint
1. Harvester can connect to the vShpere client dashboard and API endpoint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, vSphere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the check. Update the typos to vSphere.

```
1. Check can list the image list on OpenStack Server
```
openstack image list --os-auth-url http://172.19.109.182/identity --os-identity-api-version 3 --os-project-name admin --os-project-domain-name default --os-username <username> --os-password <password>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid IP exposing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the check. Remove the IP exposed on the check image command.

@albinsun albinsun requested a review from a team September 11, 2024 01:23
@TachunLin TachunLin force-pushed the manual-vm-import-enhance branch from b5a93bb to 85afea3 Compare September 12, 2024 05:13
Copy link
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushboo-rancher khushboo-rancher merged commit 52c6a4e into harvester:main Sep 12, 2024
3 checks passed
@irishgordo
Copy link
Contributor

Thanks for this addition @TachunLin ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants