fix: 1568 Fixing S3 Connection Building #1580
Conversation
* fixes s3 connection building, allowing us to wait for a short period of time to allow the secret for longhorn-system to be built on Harvester side Resovles: fix/1568 See also: harvester#1568
| @@ -121,6 +121,8 @@ def config_backup_target(api_client, conflict_retries, backup_config, wait_timeo | |||
| f'Failed to update backup target to {backup_type} with {config}\n' | |||
| f"API Status({code}): {data}" | |||
| ) | |||
| # sleeping to allow longhorn secret to be built on Harvester side | |||
| sleep(5) | |||
There was a problem hiding this comment.
Do we have any way of checking the secret existence? Can we check that in a loop with some sleep?
There was a problem hiding this comment.
Could we loop through checking the status of the backup target by looping through something like api_client.settings.backup_target_test_connection? Will that return true if the secret isn't there?
|
I've converted this back to "draft" as the fix will require checking a status on Longhorn that @lanfon72 was mentioning .
It's not that this test is "failing" per say due to the test itself it's the hardware + network based setup that is impacting this test. When running locally or over faster storage + network -> test failures happens less frequently. |
Resovles: fix/1568
See also: #1568
Which issue(s) this PR fixes:
Fixes #1568
What this PR does / why we need it:
Adds a bit of time before yielding back the backup config -> as Harvester takes a bit more time usually for it to have the secret built in longhorn-system in v1.4.0-rc1
Additional documentation or context
In the video, it is demo'd with an external bare-metal hp dl160 2 node v1.4.0-rc1 cluster that we can indeed replicate the issue outlined in 1568. We see we are moving to fast trying to build the fixture and the secret hasn't yet built on Harvester side in time. But if we give it a bit of a sleep, to allow Harvester to catch up to build the secret before yielding back the spec, everything is good. The video illustrates the points back to back.
s3-connection-building-issue.mp4