Fixups and Python 3.11 Environment #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixups: - Remove debug output - Cleanup format strings in ClusterManager class Tox: - Add Python 3.11 environment - Drop Python 3.6 environment Revert change to two assignment expressions. Without the need to further support Python 3.6 assignment expressions can be used in conditionals, i.e. `if (cs := data.get(...)):`. Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
khushboo-rancher
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixups:
Tox:
Revert change to two assignment expressions. Without the need to further support Python 3.6 assignment expressions can be used in conditionals, i.e.
if (cs := data.get(...)):.Which issue(s) this PR fixes:
This PR addresses suggestions on a previous PR.
What this PR does / why we need it:
Following the suggestions on PR1628 that were made after that PR had already been merged, this PR is a simple clean up.
Special notes for your reviewer:
There are no new tests, no removed tests and no changes to functionality. However support for Python 3.6 has been dropped and as replacement support for Python 3.11 has been added to the tox config.