[Cypress] Fix failed tests in v1.4.0-rc5 and v1.4.0 #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TachunLin
requested review from
a110605,
torchiaf,
khushboo-rancher and
noahgildersleeve
a110605
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks @TachunLin make cypress tests compatible to v1.4.0.
but cypress/.package-lock.json.swp is not required in this PR, right ?
a110605
reviewed
Dec 9, 2024
| @@ -153,20 +153,20 @@ export class VmsPage extends CruResourcePo { | |||
|
|
|||
| clickVMSnapshotAction(name: string, snapshotName: string) { | |||
| this.clickAction(name, 'Take Virtual Machine Snapshot'); | |||
| cy.get('.v--modal-box .card-title').find('h4').contains('Take Virtual Machine Snapshot'); | |||
| cy.get('.modal-container .card-title').find('h4').contains('Take Virtual Machine Snapshot'); | |||
There was a problem hiding this comment.
Related PR : harvester/dashboard#1187
|
Thanks @a110605 for the review and check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #1535
What this PR does / why we need it:
Continue from the previous PR: #1588.
After fixed the cypress script for v1.4.0 string changes, we still have
22failed tests.This pull request is based on the fix already works on
v1.4.0-rc5.According to the following result:
And verified the entire cypress test suite on official
v1.4.0release to improve some flaky and unstable issue.Test Result - fixed the following test cases:
Verified on
v1.4.0to confirm can PASS the following cypress testsFix all tests in the vmBackup.spec.ts
Fix all tests in the vmSnapshot.spec.ts
Fix all tests in the volumeSnapshot.spec.ts
Fix one test in the hosts.spec.ts
Check edit hostsFix one test in the image.spec.ts
Image filtering by labelsFix two tests in the virtual-machine.spec.ts
VM RunStategy Validation (Halted)All Namespace filtering in VM listFix two tests in the volumes.spec.ts
Support Volume Hot UnplugEdit volume increase size via formSetup Test Environment (Similar to the Jenkins pipeline jobs)
We can use the ipxe-example to build the cypress test environment similar with the Jenkins pipeline job.
harvester_cluster_nodes: 3andrancher_config.enabled: trueFollow the steps to setup docker and minio container service
https://confluence.suse.com/display/HARV/Setup+Harvester+Related+Endpoints#SetupHarvesterRelatedEndpoints-S3
Clone the pr of harvester/tests
Replace the
cypress.env.jsonwith the following one (Used for the Jenkins pipeline, reduce the time find configuration)Run
npm installto install depdenciesRun
npm cito install cypressThen we can trigger the test from our local environment using
npm runornpm openSpecial notes for your reviewer:
If you plan to test specific test spec file instead of the entire e2e test run.
Ensure to run the
0_FirstTimeLogin.spec.tsand1_login.spec.tsbefore testing any specific test suite file