-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing props through remote component #1
Comments
This is a valid request; I don't know how I missed this on the initial implementation :) However, to implement this, I would like to ask for your help because even if I made the change, I can't test this anytime soon. So, could you please open a PR for this? all changes have to be in RemoteComponent.tsx, 1- add new line after line 10, and add a new property called |
Thanks for the swift reply, sure I would be more than happy to test this out :) |
It's in PR, thanks again 👍 |
So is this PR going to be pushed into main? |
sorry guys, I haven't merged this PR because I wanted better type support for the RemoteComponent. it's now a generic component which lets you set the props you want to pass to it with a generic type. I could not test it myself as the dependencies seem to be quite old and I've been away from CRA world. I don't have time to get back into it now. Could you please install the latest version (0.0.5) and test it? Here is a usage example
|
Hi there, is there a way to pass props to the remote component, for instance:
Currently I believe this would just render Hello as the props object "sent" to App is empty.
The text was updated successfully, but these errors were encountered: