Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup for consul ent testing #1831

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Setup for consul ent testing #1831

merged 3 commits into from
Nov 14, 2023

Conversation

roncodingenthusiast
Copy link
Contributor

@roncodingenthusiast roncodingenthusiast commented Nov 7, 2023 •
edited
Loading

  • allow us to run consul with enterprise binary for testing enterprise feature
Screenshot 2023-11-08 at 1 40 51 PM

@roncodingenthusiast roncodingenthusiast marked this pull request as ready for review November 8, 2023 18:40
@roncodingenthusiast roncodingenthusiast requested review from a team, johnlanda and kisunji and removed request for a team November 8, 2023 18:40
@skpratt skpratt requested a review from lkysow November 9, 2023 16:14
johnlanda
johnlanda approved these changes Nov 14, 2023
View reviewed changes
Copy link

@johnlanda johnlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Regarding the latest vs specific versions, I lean towards always pinning things to a particular version in general. Feels like the more conservative approach even though it does mean some extra work to come and update as needed.

@roncodingenthusiast roncodingenthusiast merged commit 76dce63 into main Nov 14, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisunji kisunji kisunji approved these changes

@skpratt skpratt skpratt approved these changes

@johnlanda johnlanda johnlanda approved these changes

@lkysow lkysow Awaiting requested review from lkysow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roncodingenthusiast @johnlanda @skpratt @kisunji