Fix lint errors/deprecated golangci opts

.golangci.yml

@@ -19,16 +19,16 @@ issues:
   # Disable the default exclude list so that all excludes are explicitly
   # defined in this file.
   exclude-use-default: false
-
+  exclude-rules:
+    - text: 'shadow: declaration of "(err|ctx)" shadows declaration at'
+      linters: [ govet ]
 
 linters-settings:
   govet:
-    check-shadowing: true
     enable-all: true
     disable:
       - fieldalignment
       - nilness
-      - shadow
       - unusedwrite
   forbidigo:
     # Forbid the following identifiers (list of regexp).

child/command-prep.go

@@ -24,8 +24,8 @@ func CommandPrep(command []string) ([]string, bool, error) {
 		if _, err := exec.LookPath(shell); err != nil {
 			shell = ""
 			for _, sh := range []string{"/bin/sh", "/usr/bin/sh"} {
-				if sh, err := exec.LookPath(sh); err == nil {
-					shell = sh
+				if absPath, err := exec.LookPath(sh); err == nil {
+					shell = absPath
 					break
 				}
 			}

config/nomad_test.go

@@ -201,9 +201,9 @@ func TestNomadConfig_Finalize(t *testing.T) {
 	// This test is envvar sensitive, so there are a whole lot of them that need
 	// to be backed up and reset after the test
 	nomadVars := make(map[string]string)
-	for _, v := range os.Environ() {
-		if strings.HasPrefix(v, "NOMAD_") {
-			k, v, found := strings.Cut(v, "=")
+	for _, envVar := range os.Environ() {
+		if strings.HasPrefix(envVar, "NOMAD_") {
+			k, v, found := strings.Cut(envVar, "=")
 			if found {
 				nomadVars[k] = v
 				os.Unsetenv(k)

manager/runner.go

@@ -768,9 +768,9 @@ func (r *Runner) runTemplate(tmpl *template.Template, runCtx *templateRunCtx) (*
 	// in once mode, and we certainly do not want to re-run any commands.
 	if r.config.Once {
 		r.renderEventsLock.RLock()
-		event, ok := r.renderEvents[tmpl.ID()]
+		onceEvent, ok := r.renderEvents[tmpl.ID()]
 		r.renderEventsLock.RUnlock()
-		if ok && (event.WouldRender || event.DidRender) {
+		if ok && (onceEvent.WouldRender || onceEvent.DidRender) {
 			log.Printf("[DEBUG] (runner) once mode and already rendered")
 			return nil, nil
 		}