also pass down max conns per host to consul and nomad http transports #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @ccapurso, any chance to have a look on that? |
ccapurso
approved these changes
Jun 6, 2024
|
@ccapurso this consul-enterprise test doesn't look to be related to the patch |
|
@ccapurso is there anything else needed to merge this? |
|
can this be merged anytime soon? |
Signed-off-by: n-marton <marton@natko.hu>
n-marton
force-pushed
the
fix/maxconns
branch
from
854c317
to
00ca8b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up #1858 and #1840 this change also makes use of the max_conns_per_host param for nomad and consul clients to make it consistent and to prevent dosing there
cc @ccapurso